Hydrogen: fix keyed loads with string keys

test/mjsunit/generic-monorphic-keyed-load.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax
 
-function f_13(x, y, z) { }
 
-v_5 = f_13.bind({}, -7);
-
-function f_0(z) {
-  return %NewObjectFromBound(v_5);
+var o = {
+  "foo": "bar",
 }
 
-function f_8(z2, y2) {
-  var v_0 = { f1 : 0.5, f2 : 0.25 };
-  return f_0(v_0);
+function get(obj, key) {
+  return obj[key];
 }
 
-function f_12(f, args) {
-  f.apply(this, args);
-  %OptimizeFunctionOnNextCall(f);
-  f.apply(this, args);
-}
+get(o, "foo");
+get(o, "foo");
+get(o, "foo");
 
-f_12(f_8, [6, 4]);
+// At this point, lookup in `get` should be aware of the key type and
+// generate KeyedLoadGeneric, instead of element access and deopt check

[Jakob Kummerow, 2014/12/11 09:52:42]

nit: missing punctuation at the end.
Or you could just drop the comment. The test case doesn't really care what code
is generated.

+%OptimizeFunctionOnNextCall(get);
+get(o, "foo");
+
+// Should not deoptimize

[Jakob Kummerow, 2014/12/11 09:52:42]

nit: same here. Again, just drop it. It's obvious what the next line does.

+assertTrue(%GetOptimizationStatus(get) != 2);

[Jakob Kummerow, 2014/12/11 09:52:42]

Use "assertOptimized(get);" here.