pkg/stack_trace/lib/src/frame.dart - Issue 75543013: Make the stack_trace package print relative URLs for browser paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/stack_trace/lib/src/frame.dart

Issue 75543013: Make the stack_trace package print relative URLs for browser paths. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/stack_trace/lib/src/frame.dart

diff --git a/pkg/stack_trace/lib/src/frame.dart b/pkg/stack_trace/lib/src/frame.dart

index 6a88a268c93a6d09d8064c81090dd9713ace6b7b..74aafcda319f767b59f0ad4dec4552d965115a54 100644

--- a/pkg/stack_trace/lib/src/frame.dart

+++ b/pkg/stack_trace/lib/src/frame.dart

@@ -69,7 +69,8 @@ class Frame {

/// This will usually be the string form of [uri], but a relative URI will be

/// used if possible.

String get library {

- if (uri.scheme != 'file') return uri.toString();

+ if (uri.scheme != Uri.base.scheme) return uri.toString();

+ if (path.style == path.Style.url) return path.relative(uri.toString());

Bob Nystrom 2013/11/20 20:21:22 Don't forget to update the pubspec for stack_trace

nweiz 2013/11/20 21:01:48 Done.

return path.relative(path.fromUri(uri));

}

« no previous file with comments | « pkg/path/lib/path.dart ('k') | pkg/stack_trace/test/frame_test.dart » ('j') | no next file with comments »