Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 75543004: Support GTest's spellings for its options. (Closed)

Created:
7 years, 1 month ago by Jeffrey Yasskin
Modified:
7 years, 1 month ago
Reviewers:
bulach, Isaac (away), frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Support GTest's spellings for its options. In the build/android/test_runner.py tool. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/android/test_runner.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jeffrey Yasskin
I wasn't sure whether to add a TODO to remove the incompatible spellings.
7 years, 1 month ago (2013-11-18 21:16:23 UTC) #1
bulach
lgtm, thanks! I'm not sure if bots / trybots use any of these flags: if ...
7 years, 1 month ago (2013-11-19 12:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/75543004/1
7 years, 1 month ago (2013-11-19 16:16:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=176243
7 years, 1 month ago (2013-11-19 18:39:14 UTC) #4
frankf
On 2013/11/19 18:39:14, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-19 18:44:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/75543004/1
7 years, 1 month ago (2013-11-19 19:28:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=176405
7 years, 1 month ago (2013-11-20 02:03:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/75543004/1
7 years, 1 month ago (2013-11-20 03:26:42 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 04:38:06 UTC) #9
Message was sent while issue was closed.
Change committed as 236149

Powered by Google App Engine
This is Rietveld 408576698