Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 75543003: events: Fix running events-unittests under valgrind/heapcheck. (Closed)

Created:
7 years, 1 month ago by sadrul
Modified:
7 years, 1 month ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

events: Fix running events-unittests under valgrind/heapcheck. R=oshima@chromium.org TBR=glider@chromium.org BUG=320113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/heapcheck/chrome_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
7 years, 1 month ago (2013-11-18 19:22:33 UTC) #1
oshima
lgtm
7 years, 1 month ago (2013-11-18 19:24:57 UTC) #2
sadrul
+glider@ for valgrind
7 years, 1 month ago (2013-11-18 19:31:25 UTC) #3
sadrul
I am going to TBR glider@ for the valgrind change
7 years, 1 month ago (2013-11-18 21:56:50 UTC) #4
sadrul
7 years, 1 month ago (2013-11-18 22:11:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r235829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698