Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 755383002: Fix overflow check when shifting unboxed mints on 32-bit platforms, except on (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 3453 matching lines...) Expand 10 before | Expand all | Expand 10 after
3464 __ movsxd(out, value); 3464 __ movsxd(out, value);
3465 } else { 3465 } else {
3466 ASSERT(from_representation() == kUnboxedUint32); 3466 ASSERT(from_representation() == kUnboxedUint32);
3467 __ movl(out, value); 3467 __ movl(out, value);
3468 } 3468 }
3469 __ SmiTag(out); 3469 __ SmiTag(out);
3470 } 3470 }
3471 3471
3472 3472
3473 LocationSummary* BoxInt64Instr::MakeLocationSummary(Isolate* isolate, 3473 LocationSummary* BoxInt64Instr::MakeLocationSummary(Isolate* isolate,
3474 bool opt) const { 3474 bool opt) const {
3475 const intptr_t kNumInputs = 1; 3475 const intptr_t kNumInputs = 1;
3476 const intptr_t kNumTemps = 0; 3476 const intptr_t kNumTemps = 0;
3477 LocationSummary* summary = new(isolate) LocationSummary( 3477 LocationSummary* summary = new(isolate) LocationSummary(
3478 isolate, 3478 isolate,
3479 kNumInputs, 3479 kNumInputs,
3480 kNumTemps, 3480 kNumTemps,
3481 ValueFitsSmi() ? LocationSummary::kNoCall 3481 ValueFitsSmi() ? LocationSummary::kNoCall
3482 : LocationSummary::kCallOnSlowPath); 3482 : LocationSummary::kCallOnSlowPath);
3483 summary->set_in(0, Location::RequiresRegister()); 3483 summary->set_in(0, Location::RequiresRegister());
3484 summary->set_out(0, Location::RequiresRegister()); 3484 summary->set_out(0, Location::RequiresRegister());
(...skipping 2899 matching lines...) Expand 10 before | Expand all | Expand 10 after
6384 __ movq(R10, Immediate(kInvalidObjectPointer)); 6384 __ movq(R10, Immediate(kInvalidObjectPointer));
6385 __ movq(RBX, Immediate(kInvalidObjectPointer)); 6385 __ movq(RBX, Immediate(kInvalidObjectPointer));
6386 #endif 6386 #endif
6387 } 6387 }
6388 6388
6389 } // namespace dart 6389 } // namespace dart
6390 6390
6391 #undef __ 6391 #undef __
6392 6392
6393 #endif // defined TARGET_ARCH_X64 6393 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698