Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Issue 755363004: Make the sort order in thumbnail view always alphabetical. (Closed)

Created:
6 years ago by fukino
Modified:
6 years ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the sort order in thumbnail view always alphabetical. Implemented sort related wrapper to ListContainer to fix the actual sort order in thumbnail view in alphabetical order. BUG=438915 TEST=sort files non-alphabetically in list view, change view to grid view, and confirm the sort order is alphabetical. After that, change view to list view, and confirm that the first sort order is restored. Committed: https://crrev.com/bd854587a2e1b3ca8e7b13299e3d74978b1933f9 Cr-Commit-Position: refs/heads/master@{#307233}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add browser_test for sorting order in grid view. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -32 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/grid_view.js View 1 3 chunks +124 lines, -29 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/app_state_controller.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/list_container.js View 4 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
fukino
PTAL the CL? Thank you!
6 years ago (2014-12-05 07:40:30 UTC) #2
hirono
Can we add browser_tests for the case? The logic a bit complex. https://codereview.chromium.org/755363004/diff/1/ui/file_manager/file_manager/foreground/js/ui/list_container.js File ui/file_manager/file_manager/foreground/js/ui/list_container.js ...
6 years ago (2014-12-08 07:29:00 UTC) #3
fukino
Thanks! I added a browser_test to check the sort order in grid view. Could you ...
6 years ago (2014-12-08 10:16:32 UTC) #4
hirono
lgtm! Thanks!
6 years ago (2014-12-08 11:14:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755363004/20001
6 years ago (2014-12-08 11:53:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 12:59:55 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bd854587a2e1b3ca8e7b13299e3d74978b1933f9 Cr-Commit-Position: refs/heads/master@{#307233}
6 years ago (2014-12-08 13:00:37 UTC) #9
ilja
6 years ago (2014-12-10 05:36:18 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/789133002/ by ihf@chromium.org.

The reason for reverting is: Speculative revert for crbug.com/440659..

Powered by Google App Engine
This is Rietveld 408576698