Fix chrome upload with content uri

Fix chrome upload with content uri

For android, the upload file dialog returns files with content uri scheme(content://).
This CL makes it possible for upload to work with this new file type.
It fixes both the form and fileapi based uploads.

BUG=278640
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236192

[qinmin, 2013-11-18 19:46:58]

Reviewers, this CL is cloned from https://codereview.chromium.org/46303005/,
PTAL.

The previous submit breaks some android tests(however, the trybot does not show
meaningful stack), and this CL should fix that.

Compared to the previous CL, the only change happens in base.gyp. The java file
needs to be added to test_support_base target.

[mmenke1, 2013-11-18 19:48:56]

On 2013/11/18 19:46:58, qinmin wrote:
> Reviewers, this CL is cloned from https://codereview.chromium.org/46303005/,
> PTAL.
> 
> The previous submit breaks some android tests(however, the trybot does not
show
> meaningful stack), and this CL should fix that.
> 
> Compared to the previous CL, the only change happens in base.gyp. The java
file
> needs to be added to test_support_base target.

Just for future reference, uploading your original CL before uploading the
modified CL makes it much easier to see what you changed.

[mmenke, 2013-11-18 19:52:54]

Your "bug=" line is incorrect.

net/ LGTM

[Tom Sepez, 2013-11-18 19:57:23]

Messages LGTM.

[qinmin, 2013-11-18 19:59:47]

On 2013/11/18 19:52:54, mmenke wrote:
> Your "bug=" line is incorrect.
> 
> net/ LGTM


fixed bug id

[Yaron, 2013-11-18 21:52:14]

ui/android lgtm

[qinmin, 2013-11-19 17:34:07]

jar@, would you please re-approve this? only one-line change in base.gyp from
the last approval. Thanks

[jar (doing other things), 2013-11-20 02:39:27]

base lgtm (based on comment that this is a one line addition to the gyp file we
already reviewed)

[commit-bot: I haz the power, 2013-11-20 03:26:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/75533002/150001

[commit-bot: I haz the power, 2013-11-20 03:26:24]

Failed to apply patch for base/android/base_jni_registrar.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/android/base_jni_registrar.cc
  Hunk #1 FAILED at 6.
  Hunk #2 succeeded at 36 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
base/android/base_jni_registrar.cc.rej

Patch:       base/android/base_jni_registrar.cc
Index: base/android/base_jni_registrar.cc
diff --git a/base/android/base_jni_registrar.cc
b/base/android/base_jni_registrar.cc
index
0645c73030ce96b0f3e00c8dc209bbf2b42a0098..60ce975c14ba362133c3e0cb7213543f95fb7032
100644
--- a/base/android/base_jni_registrar.cc
+++ b/base/android/base_jni_registrar.cc
@@ -6,6 +6,7 @@
 
 #include "base/android/activity_status.h"
 #include "base/android/build_info.h"
+#include "base/android/content_uri_utils.h"
 #include "base/android/cpu_features.h"
 #include "base/android/important_file_writer_android.h"
 #include "base/android/java_handler_thread.h"
@@ -34,6 +35,7 @@ static RegistrationMethod kBaseRegisteredMethods[] = {
 #if defined(GOOGLE_TV)
   { "ContextTypes", base::android::RegisterContextTypes },
 #endif
+  { "ContentUriUtils", base::RegisterContentUriUtils },
   { "CpuFeatures", base::android::RegisterCpuFeatures },
   { "ImportantFileWriterAndroid",
     base::android::RegisterImportantFileWriterAndroid },

[commit-bot: I haz the power, 2013-11-20 03:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/75533002/270001

[commit-bot: I haz the power, 2013-11-20 07:04:57]

Change committed as 236192

[eugenis, 2013-12-02 14:28:54]

https://codereview.chromium.org/75533002/diff/270001/base/file_util_unittest.cc
File base/file_util_unittest.cc (right):

https://codereview.chromium.org/75533002/diff/270001/base/file_util_unittest....
base/file_util_unittest.cc:2364: EXPECT_GT(0, size);
This does not look right. In case of failure GetFileSize exits without setting
file size, and this code is testing an uninitialized stack location.

This is the cause of this failure:
http://build.chromium.org/p/chromium.fyi/builders/Android%20Asan%20Builder%20...

[qinmin, 2013-12-02 17:35:46]

https://codereview.chromium.org/75533002/diff/270001/base/file_util_unittest.cc
File base/file_util_unittest.cc (right):

https://codereview.chromium.org/75533002/diff/270001/base/file_util_unittest....
base/file_util_unittest.cc:2364: EXPECT_GT(0, size);
uploaded https://codereview.chromium.org/93963003/  to fix this.

On 2013/12/02 14:28:54, eugenis wrote:
> This does not look right. In case of failure GetFileSize exits without setting
> file size, and this code is testing an uninitialized stack location.
> 
> This is the cause of this failure:
>
http://build.chromium.org/p/chromium.fyi/builders/Android%2520Asan%2520Builde...