Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests on Linux Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_unittest.py
diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py
index 4a9ff7301160b8d20cf2a6089bf051c213ced7e8..572b1c2fcaf2cbf2ea5bc0a623298acb1f3498af 100644
--- a/tools/perf/measurements/smoothness_unittest.py
+++ b/tools/perf/measurements/smoothness_unittest.py
@@ -8,7 +8,6 @@ from metrics import power
from telemetry.core import exceptions
from telemetry.core import wpr_modes
from telemetry.page import page
-from telemetry.page import page_test
from telemetry.unittest_util import options_for_unittests
from telemetry.unittest_util import page_test_test_case
from telemetry.unittest_util import test
@@ -176,7 +175,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
measurement = BuggyMeasurement()
try:
self.RunMeasurement(measurement, ps)
- except page_test.TestNotSupportedOnPlatformFailure:
+ except exceptions.IntentionalException:
nednguyen 2014/12/13 00:20:23 I am pretty sure that this is not the correct fix.
nednguyen 2014/12/13 00:33:11 nvm, TestNotSupportedOnPlatformFailure is only rai
pass
self.assertTrue(measurement.fake_power.start_called)
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698