Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 755323012: [Telemetry] Stop execution for unexpected exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix screenshot exception. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 5
6 from measurements import smoothness 6 from measurements import smoothness
7 from metrics import power 7 from metrics import power
8 from telemetry.core import exceptions 8 from telemetry.core import exceptions
9 from telemetry.core import wpr_modes 9 from telemetry.core import wpr_modes
10 from telemetry.page import page 10 from telemetry.page import page
11 from telemetry.page import page_test
12 from telemetry.unittest_util import options_for_unittests 11 from telemetry.unittest_util import options_for_unittests
13 from telemetry.unittest_util import page_test_test_case 12 from telemetry.unittest_util import page_test_test_case
14 from telemetry.unittest_util import test 13 from telemetry.unittest_util import test
15 14
16 class FakeTracingController(object): 15 class FakeTracingController(object):
17 def __init__(self): 16 def __init__(self):
18 self.category_filter = None 17 self.category_filter = None
19 def Start(self, _options, category_filter, _timeout): 18 def Start(self, _options, category_filter, _timeout):
20 self.category_filter = category_filter 19 self.category_filter = category_filter
21 20
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 168
170 class BuggyMeasurement(smoothness.Smoothness): 169 class BuggyMeasurement(smoothness.Smoothness):
171 fake_power = None 170 fake_power = None
172 # Inject fake power metric. 171 # Inject fake power metric.
173 def WillStartBrowser(self, platform): 172 def WillStartBrowser(self, platform):
174 self.fake_power = self._power_metric = FakePowerMetric(platform) 173 self.fake_power = self._power_metric = FakePowerMetric(platform)
175 174
176 measurement = BuggyMeasurement() 175 measurement = BuggyMeasurement()
177 try: 176 try:
178 self.RunMeasurement(measurement, ps) 177 self.RunMeasurement(measurement, ps)
179 except page_test.TestNotSupportedOnPlatformFailure: 178 except exceptions.IntentionalException:
180 pass 179 pass
181 180
182 self.assertTrue(measurement.fake_power.start_called) 181 self.assertTrue(measurement.fake_power.start_called)
183 self.assertTrue(measurement.fake_power.stop_called) 182 self.assertTrue(measurement.fake_power.stop_called)
OLDNEW
« no previous file with comments | « tools/perf/measurements/screenshot_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698