Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 755323002: ExcServerVariants test: make the mock test port dispositions reflect reality (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

ExcServerVariants test: make the mock test port dispositions reflect reality. These port dispositions were naïvely taken from excUser.c and mach_excUser.c, but the local and remote portions were not swapped as they would be upon receipt in a server. This swaps them to match how they’d be visible in a server, and uses the port disposition name aliases expected to be used in servers: MACH_MSG_TYPE_PORT_* instead of MACH_MSG_TYPE_{MAKE,COPY,MOVE}_*. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d14fa0961a135ff1d0c4444ffb2a0ea2e19990b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M util/mach/exc_server_variants_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-11-25 17:42:43 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-11-25 19:38:08 UTC) #3
Mark Mentovai
6 years ago (2014-11-25 20:05:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d14fa0961a135ff1d0c4444ffb2a0ea2e19990b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698