Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/hydrogen.h

Issue 7553006: Check for phi-uses of arguments object before eliminating dead phi's. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 void EliminateRedundantPhis(); 235 void EliminateRedundantPhis();
236 void EliminateUnreachablePhis(); 236 void EliminateUnreachablePhis();
237 void Canonicalize(); 237 void Canonicalize();
238 void OrderBlocks(); 238 void OrderBlocks();
239 void AssignDominators(); 239 void AssignDominators();
240 void ReplaceCheckedValues(); 240 void ReplaceCheckedValues();
241 void PropagateDeoptimizingMark(); 241 void PropagateDeoptimizingMark();
242 242
243 // Returns false if there are phi-uses of the arguments-object 243 // Returns false if there are phi-uses of the arguments-object
244 // which are not supported by the optimizing compiler. 244 // which are not supported by the optimizing compiler.
245 bool CheckPhis();
246
247 // Returns false if there are phi-uses of hole values comming
248 // from uninitialized consts.
245 bool CollectPhis(); 249 bool CollectPhis();
246 250
247 Handle<Code> Compile(CompilationInfo* info); 251 Handle<Code> Compile(CompilationInfo* info);
248 252
249 void set_undefined_constant(HConstant* constant) { 253 void set_undefined_constant(HConstant* constant) {
250 undefined_constant_.set(constant); 254 undefined_constant_.set(constant);
251 } 255 }
252 HConstant* GetConstantUndefined() const { return undefined_constant_.get(); } 256 HConstant* GetConstantUndefined() const { return undefined_constant_.get(); }
253 HConstant* GetConstant1(); 257 HConstant* GetConstant1();
254 HConstant* GetConstantMinus1(); 258 HConstant* GetConstantMinus1();
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
1222 const char* filename_; 1226 const char* filename_;
1223 HeapStringAllocator string_allocator_; 1227 HeapStringAllocator string_allocator_;
1224 StringStream trace_; 1228 StringStream trace_;
1225 int indent_; 1229 int indent_;
1226 }; 1230 };
1227 1231
1228 1232
1229 } } // namespace v8::internal 1233 } } // namespace v8::internal
1230 1234
1231 #endif // V8_HYDROGEN_H_ 1235 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698