Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Unified Diff: dart/pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 755223002: Always enable RTI for incremental compilation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42035. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/dart2js_incremental/lib/caching_compiler.dart
diff --git a/dart/pkg/dart2js_incremental/lib/caching_compiler.dart b/dart/pkg/dart2js_incremental/lib/caching_compiler.dart
index b2b193cdc14503b2de4433445d935d8546b00158..a20e8340dcec0b2d7970071e09ebde20127ad501 100644
--- a/dart/pkg/dart2js_incremental/lib/caching_compiler.dart
+++ b/dart/pkg/dart2js_incremental/lib/caching_compiler.dart
@@ -65,10 +65,20 @@ Future<Compiler> reuseCompiler(
options,
environment);
JavaScriptBackend backend = compiler.backend;
+
// Much like a scout, an incremental compiler is always prepared. For
// mixins, at least.
backend.emitter.oldEmitter.needsMixinSupport = true;
- return new Future.value(compiler);
+
+ Uri core = Uri.parse("dart:core");
+ return compiler.libraryLoader.loadLibrary(core).then((_) {
+ // Likewise, always be prepared for runtimeType support.
+ // TODO(johnniwinther): Add global switch to force RTI.
+ compiler.enabledRuntimeType = true;
+ backend.registerRuntimeType(
+ compiler.enqueuer.resolution, compiler.globalDependencies);
+ return compiler;
+ });
} else {
for (final task in compiler.tasks) {
if (task.watch != null) {
« no previous file with comments | « no previous file | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698