Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 7552031: Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening ... (Closed)

Created:
7 years, 10 months ago by kerz_chromium
Modified:
7 years, 10 months ago
Reviewers:
caseq
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector https://bugs.webkit.org/show_bug.cgi?id=65912 Reviewed by Pavel Feldman. * inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): TBR=caseq@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M Source/WebCore/ChangeLog View 1 chunk +38 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kerz_chromium
7 years, 10 months ago (2011-08-10 01:39:57 UTC) #1
caseq
On 2011/08/10 01:39:57, kerz_chromium wrote: LGTM
7 years, 10 months ago (2011-08-10 07:46:18 UTC) #2
caseq
On 2011/08/10 07:46:18, caseq wrote: > On 2011/08/10 01:39:57, kerz_chromium wrote: > > LGTM One ...
7 years, 10 months ago (2011-08-10 07:48:01 UTC) #3
kerz_chromium
7 years, 10 months ago (2011-08-10 07:59:54 UTC) #4
ChangeLog is ignored on the branch, so no worries.

On Wed, Aug 10, 2011 at 12:48 AM, <caseq@chromium.org> wrote:

> On 2011/08/10 07:46:18, caseq wrote:
>
>> On 2011/08/10 01:39:57, kerz_chromium wrote:
>>
>
>  LGTM
>>
>
> One note, though -- there are two entries in the ChangeLog diff, second is
> unrelated.
>
>
>
http://codereview.chromium.**org/7552031/<http://codereview.chromium.org/7552...
>

Powered by Google App Engine
This is Rietveld 408576698