Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 755183004: GN + Android: allow to set visibility on android_library targets. (Closed)

Created:
6 years ago by ppi
Modified:
6 years ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN + Android: allow to set visibility on android_library targets. R=cjhopman@chromium.org BUG=None Committed: https://crrev.com/97ce2aed19d80cb905bdf7a165fd212fbdde54da Cr-Commit-Position: refs/heads/master@{#305717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Chris, does that look reasonable?
6 years ago (2014-11-25 18:52:36 UTC) #1
cjhopman
lgtm
6 years ago (2014-11-25 19:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755183004/1
6 years ago (2014-11-25 22:13:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-25 23:00:50 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 23:02:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97ce2aed19d80cb905bdf7a165fd212fbdde54da
Cr-Commit-Position: refs/heads/master@{#305717}

Powered by Google App Engine
This is Rietveld 408576698