Support presentational iframes and make use of them in the uber frame.

Support presentational iframes and make use of them in the uber frame.

A presentational iframe, e.g. <iframe role="presentation">, is one where the
web author is indicating that the frame is an implementation detail. Suppress
the normal role for the frame and for its inner document / web area, so that
accessibility clients see the frame as if it was part of the parent document.

Make use of this in the uber frame for settings, history, and extensions.

BUG=436186
Committed: https://crrev.com/8b43c604a8a5ca11bdf01b12a7c2f34f2bfcc54f
Cr-Commit-Position: refs/heads/master@{#308859}

[dmazzoni, 2014-12-01 20:04:25]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org, dbeam@chromium.org

[dmazzoni, 2014-12-01 20:04:26]

(Depends on: https://codereview.chromium.org/766053006/)

aboxhall: presentational iframe support
dbeam: uber frame changes

[Dan Beam, 2014-12-03 00:57:09]

lgtm

https://codereview.chromium.org/755173004/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.html (right):

https://codereview.chromium.org/755173004/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.html:23: <div id="navigation"><iframe
src="chrome://uber-frame/" name="chrome" role="presentation"></iframe></div>
80 col wrap (unfortunate that it was already over...)

[aboxhall, 2014-12-03 23:46:17]

lgtm

https://codereview.chromium.org/755173004/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/automation.idl (right):

https://codereview.chromium.org/755173004/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/automation.idl:101: iframePresentational,
Should we do anything special with this in the automation API? Based on
browser_accessibility[_win].cc it looks like we probably should. Feel free to
add a TODO for me or David to do something.

https://codereview.chromium.org/755173004/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/755173004/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility.cc:688:
BrowserAccessibility* parent = GetParent();
What is the parent going to be, out of curiosity?

[dmazzoni, 2014-12-17 18:30:27]

https://codereview.chromium.org/755173004/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/automation.idl (right):

https://codereview.chromium.org/755173004/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/automation.idl:101: iframePresentational,
On 2014/12/03 23:46:17, aboxhall wrote:
> Should we do anything special with this in the automation API? Based on
> browser_accessibility[_win].cc it looks like we probably should. Feel free to
> add a TODO for me or David to do something.

My initial thought is for the automation api to virtually ignore iframes
entirely and treat them as an implementation detail. It should be rare that an
automation tool or AT should actually care

https://codereview.chromium.org/755173004/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/755173004/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility.cc:688:
BrowserAccessibility* parent = GetParent();
On 2014/12/03 23:46:17, aboxhall wrote:
> What is the parent going to be, out of curiosity?

Currently the parent is a scrollpane and the grandparent is the iframe element

[dmazzoni, 2014-12-17 20:47:19]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-12-17 20:47:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755173004/20001

[commit-bot: I haz the power, 2014-12-17 21:23:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-17 21:24:51]

Patchset 2 (id:??) landed as
https://crrev.com/8b43c604a8a5ca11bdf01b12a7c2f34f2bfcc54f
Cr-Commit-Position: refs/heads/master@{#308859}