Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 755143005: gn format // regressions (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
tfarina, armansito, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, ben+mojo_chromium.org, darin (slow to review), jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format // regressions Presubmit added here: https://codereview.chromium.org/779383004/. TBR=brettw@chromium.org, armansito@chromium.org BUG=348474 Committed: https://crrev.com/6da1b58aa68bfd663b92fcd84c6cd52a29f2d9f7 Cr-Commit-Position: refs/heads/master@{#307281}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +2 lines, -1 line 1 comment Download
M content/shell/android/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M device/vibration/BUILD.gn View 3 chunks +3 lines, -7 lines 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
scottmg
armansito for device/bluetooth brettw for rest.
6 years ago (2014-12-08 17:47:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755143005/20001
6 years ago (2014-12-08 17:48:03 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 18:31:23 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6da1b58aa68bfd663b92fcd84c6cd52a29f2d9f7 Cr-Commit-Position: refs/heads/master@{#307281}
6 years ago (2014-12-08 18:32:14 UTC) #6
tfarina
6 years ago (2014-12-13 15:49:44 UTC) #8
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/755143005/diff/20001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/755143005/diff/20001/chrome/android/BUILD.gn#...
chrome/android/BUILD.gn:362: chrome_sync_shell_manifest =
I had this in https://codereview.chromium.org/782183002/, looks like I was late
to land it :(

Powered by Google App Engine
This is Rietveld 408576698