Advertise Opus support in EME.

Advertise Opus support in EME.

BUG=417398
Committed: https://crrev.com/5ec6dcf5f219f913f7649f2ec4a6bd039cecb6bc
Cr-Commit-Position: refs/heads/master@{#305878}

[sandersd (OOO until July 31), 2014-11-25 19:30:02]

sandersd@chromium.org changed reviewers:
+ ddorwin@chromium.org, jrummell@chromium.org

[sandersd (OOO until July 31), 2014-11-25 19:30:02]

sandersd@chromium.org changed required reviewers:
+ jrummell@chromium.org

[ddorwin, 2014-11-25 20:54:51]

Thanks. LG at a high-level. I'll let jrummell review the details.

https://codereview.chromium.org/755143004/diff/1/media/base/key_systems.cc
File media/base/key_systems.cc (right):

https://codereview.chromium.org/755143004/diff/1/media/base/key_systems.cc#ne...
media/base/key_systems.cc:84: info.supported_codecs = EME_CODEC_WEBM_ALL;
In a separate CL, we should stop using _ALL, which will also replace the
removals below with just not adding them.

[jrummell, 2014-11-25 21:37:12]

lgtm w/nit.

https://codereview.chromium.org/755143004/diff/1/chrome/renderer/media/chrome...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/755143004/diff/1/chrome/renderer/media/chrome...
chrome/renderer/media/chrome_key_systems.cc:159: SupportedCodecs
supported_codecs = media::EME_CODEC_NONE;
nit: Should this be = EME_CODEC_WEBM_AUDIO_ALL, and then only add
EME_CODEC_MP4_AAC conditionally?

[sandersd (OOO until July 31), 2014-11-25 21:46:40]

https://codereview.chromium.org/755143004/diff/1/chrome/renderer/media/chrome...
File chrome/renderer/media/chrome_key_systems.cc (right):

https://codereview.chromium.org/755143004/diff/1/chrome/renderer/media/chrome...
chrome/renderer/media/chrome_key_systems.cc:159: SupportedCodecs
supported_codecs = media::EME_CODEC_NONE;
On 2014/11/25 21:37:12, jrummell wrote:
> nit: Should this be = EME_CODEC_WEBM_AUDIO_ALL, and then only add
> EME_CODEC_MP4_AAC conditionally?

No, a specific goal is to remove _ALL from use everywhere.

[ddorwin, 2014-11-25 22:38:39]

lgtm

[sandersd (OOO until July 31), 2014-11-25 22:44:00]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-11-25 22:44:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755143004/20001

[commit-bot: I haz the power, 2014-11-26 00:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-26 00:42:21]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[sandersd (OOO until July 31), 2014-11-26 19:38:38]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-11-26 19:39:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/755143004/40001

[commit-bot: I haz the power, 2014-11-26 20:39:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-26 20:40:30]

Patchset 3 (id:??) landed as
https://crrev.com/5ec6dcf5f219f913f7649f2ec4a6bd039cecb6bc
Cr-Commit-Position: refs/heads/master@{#305878}