Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 75513005: We cannot use the value stored in a typed array for load elimination, but we should still kill save… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/typed_data/typed_data_load_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 30353)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -1649,9 +1649,6 @@
void visitIndexAssign(HIndexAssign instruction) {
HInstruction receiver = instruction.receiver.nonCheck();
- JavaScriptBackend backend = compiler.backend;
- // Typed arrays may narrow incoming values.
- if (backend.couldBeTypedArray(receiver.instructionType)) return;
memorySet.registerKeyedValueUpdate(
receiver, instruction.index, instruction.value);
}
@@ -1832,6 +1829,10 @@
}
});
+ JavaScriptBackend backend = compiler.backend;
+ // Typed arrays may narrow incoming values.
+ if (backend.couldBeTypedArray(receiver.instructionType)) return;
+
Map<HInstruction, HInstruction> map = keyedValues.putIfAbsent(
receiver, () => <HInstruction, HInstruction> {});
map[index] = value;
« no previous file with comments | « no previous file | tests/lib/typed_data/typed_data_load_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698