Issue 7551030: Valgrind/Heapchecker: Only run presubmit check on suppression files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7551030: Valgrind/Heapchecker: Only run presubmit check on suppression files. (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:
stuartmorgan, Alexander Potapenko

CC:
chromium-reviews, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Valgrind/Heapchecker: Only run presubmit check on suppression files. BUG=90257 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95273

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	tools/heapcheck/PRESUBMIT.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	tools/valgrind/memcheck/PRESUBMIT.py	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Timur Iskhodzhanov

you don't need to change the tools/valgrind/memcheck/PRESUBMIT.py file since this directory only contains suppression files.

9 years, 4 months ago (2011-08-03 08:26:08 UTC) #2

Timur Iskhodzhanov

Alexander wrote that, adding him as a reviewer

9 years, 4 months ago (2011-08-03 08:26:42 UTC) #3

Alexander Potapenko

On 2011/08/03 08:26:08, Timur Iskhodzhanov wrote: > you don't need to change the tools/valgrind/memcheck/PRESUBMIT.py file ...

9 years, 4 months ago (2011-08-03 08:58:11 UTC) #4

LGTM