Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 755013002: Disable CrossSiteDocumentBlockingForDifferentTargets for --site-per-process. (Closed)

Created:
6 years ago by Charlie Reis
Modified:
6 years ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable CrossSiteDocumentBlockingForDifferentTargets for --site-per-process. This test has two sibling OOPIFs from the same site, which requires widget support and updates to DidStopLoading. BUG=419087, 436250 TEST=Site isolation FYI bots go green. Committed: https://crrev.com/57921d67c45726fc7b558c5afefc495fa67acd5b Cr-Commit-Position: refs/heads/master@{#305538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/child/site_isolation_policy_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Nasko: This test used to pass because navigating the OOPIF to swappedout:// was sending a ...
6 years ago (2014-11-24 23:43:31 UTC) #2
nasko
LGTM
6 years ago (2014-11-24 23:52:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755013002/1
6 years ago (2014-11-24 23:55:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-25 00:54:35 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-25 00:56:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57921d67c45726fc7b558c5afefc495fa67acd5b
Cr-Commit-Position: refs/heads/master@{#305538}

Powered by Google App Engine
This is Rietveld 408576698