Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: mojo/public/platform/native/BUILD.gn

Issue 754963008: Simplify //mojo/public/c/system targets (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../../mojo_sdk.gni") 5 import("../../mojo_sdk.gni")
6 6
7 mojo_sdk_source_set("system_thunks") { 7 mojo_sdk_source_set("system") {
8 mojo_sdk_visibility = [
9 "mojo/public/c/system:for_component",
10 "mojo/public/c/system:for_shared_library",
11 ]
12
13 sources = [ 8 sources = [
14 "system_thunks.h", 9 "system_thunks.h",
15 "system_thunks.cc", 10 "system_thunks.cc",
16 ] 11 ]
17 defines = [ "MOJO_SYSTEM_IMPLEMENTATION" ] 12 defines = [ "MOJO_SYSTEM_IMPLEMENTATION" ]
18 mojo_sdk_deps = [ "mojo/public/c/system" ] 13 mojo_sdk_deps = [ "mojo/public/c/system" ]
19 14
20 # The GYP target analogous to this one builds this code into a 15 # The GYP target analogous to this one builds this code into a
21 # static library. When building for Android, both the GYP and GN 16 # static library. When building for Android, both the GYP and GN
22 # builds add --exclude-libs=ALL globally, which means that all 17 # builds add --exclude-libs=ALL globally, which means that all
23 # symbols in static libraries are excluded from export. That's a 18 # symbols in static libraries are excluded from export. That's a
24 # problem, as code outside this target needs to be able to call 19 # problem, as code outside this target needs to be able to call
25 # MojoSetSystemThunks(). Therefore, the GYP target needs to specifiy 20 # MojoSetSystemThunks(). Therefore, the GYP target needs to specifiy
26 # that all dependent targets remove that link flag. Since GN uses a 21 # that all dependent targets remove that link flag. Since GN uses a
27 # source_set here, this flag change is not needed. 22 # source_set here, this flag change is not needed.
28 } 23 }
29 24
30 mojo_sdk_source_set("gles2_thunks") { 25 mojo_sdk_source_set("gles2") {
31 mojo_sdk_visibility = [ "mojo/public/gles2:for_shared_library" ]
32
33 sources = [ 26 sources = [
34 "gles2_thunks.cc", 27 "gles2_thunks.cc",
35 "gles2_thunks.h", 28 "gles2_thunks.h",
36 "gles2_impl_thunks.cc", 29 "gles2_impl_thunks.cc",
37 "gles2_impl_thunks.h", 30 "gles2_impl_thunks.h",
38 "gles2_impl_chromium_texture_mailbox_thunks.cc", 31 "gles2_impl_chromium_texture_mailbox_thunks.cc",
39 "gles2_impl_chromium_texture_mailbox_thunks.h", 32 "gles2_impl_chromium_texture_mailbox_thunks.h",
40 "gles2_impl_chromium_sync_point_thunks.cc", 33 "gles2_impl_chromium_sync_point_thunks.cc",
41 "gles2_impl_chromium_sync_point_thunks.h", 34 "gles2_impl_chromium_sync_point_thunks.h",
42 ] 35 ]
43 36
44 defines = [ "MOJO_GLES2_IMPLEMENTATION" ] 37 defines = [ "MOJO_GLES2_IMPLEMENTATION" ]
45 38
46 configs = [ "//third_party/khronos:khronos_headers" ] 39 configs = [ "//third_party/khronos:khronos_headers" ]
47 40
48 mojo_sdk_deps = [ 41 mojo_sdk_deps = [
49 "mojo/public/c/gles2:headers", 42 "mojo/public/c/gles2:headers",
50 "mojo/public/c/environment", 43 "mojo/public/c/environment",
51 "mojo/public/c/system", 44 "mojo/public/c/system",
52 ] 45 ]
53 46
54 if (is_mac) { 47 if (is_mac) {
55 # TODO(GYP): Make it a run-path dependent library. 48 # TODO(GYP): Make it a run-path dependent library.
56 # 'DYLIB_INSTALL_NAME_BASE': '@loader_path', 49 # 'DYLIB_INSTALL_NAME_BASE': '@loader_path',
57 } 50 }
58 } 51 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698