Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm

Issue 754953002: Enable AutoResize for Constrained Web Dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
diff --git a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
index a924f157b0ae8d797c113655c6a3c73ffccf96b5..0589797853c3c93cfbd9d4b10ddf01a155b565ef 100644
--- a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
+++ b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
@@ -76,6 +76,18 @@ class ConstrainedWebDialogDelegateViewMac :
return constrained_window_->GetNativeDialog();
}
WebContents* GetWebContents() override { return impl_->GetWebContents(); }
+ gfx::Size GetMinimumSize() const override {
+ NOTIMPLEMENTED();
+ return gfx::Size();
+ }
+ gfx::Size GetMaximumSize() const override {
+ NOTIMPLEMENTED();
+ return gfx::Size();
+ }
+ gfx::Size GetPreferredSize() const override {
+ NOTIMPLEMENTED();
+ return gfx::Size();
+ }
// ConstrainedWindowMacDelegate interface
void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {
@@ -115,7 +127,7 @@ ConstrainedWebDialogDelegateViewMac::ConstrainedWebDialogDelegateViewMac(
impl_->set_window(constrained_window_.get());
}
-ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(
+ConstrainedWebDialogDelegate* ShowConstrainedWebDialog(
content::BrowserContext* browser_context,
WebDialogDelegate* delegate,
content::WebContents* web_contents) {

Powered by Google App Engine
This is Rietveld 408576698