Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_ui.h

Issue 754953002: Enable AutoResize for Constrained Web Dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: per miu's comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/constrained_web_dialog_ui.h
diff --git a/chrome/browser/ui/webui/constrained_web_dialog_ui.h b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
index 172fab6b2c623a89f0fc471c8a9eedd92d317e0a..f48032b80a4b9aaee01899f26be2cbb5dc0f6086 100644
--- a/chrome/browser/ui/webui/constrained_web_dialog_ui.h
+++ b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
@@ -10,6 +10,10 @@
#include "content/public/browser/web_ui_controller.h"
#include "ui/gfx/native_widget_types.h"
+namespace gfx {
+ class Size;
+}
+
namespace content {
class BrowserContext;
class RenderViewHost;
@@ -75,16 +79,23 @@ class ConstrainedWebDialogUI : public content::WebUIController {
DISALLOW_COPY_AND_ASSIGN(ConstrainedWebDialogUI);
};
-// Create a constrained HTML dialog. The actual object that gets created
-// is a ConstrainedWebDialogDelegate, which later triggers construction of a
-// ConstrainedWebDialogUI object.
+// Create and show a constrained HTML dialog. The actual object that gets
+// created is a ConstrainedWebDialogDelegate, which later triggers construction
+// of a ConstrainedWebDialogUI object.
// |browser_context| is used to construct the constrained HTML dialog's
// WebContents.
// |delegate| controls the behavior of the dialog.
// |overshadowed| is the tab being overshadowed by the dialog.
-ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(
+ConstrainedWebDialogDelegate* ShowConstrainedWebDialog(
content::BrowserContext* browser_context,
ui::WebDialogDelegate* delegate,
content::WebContents* overshadowed);
+ConstrainedWebDialogDelegate* CreateConstrainedWebDialogWithAutoResize(
miu 2014/11/26 22:17:36 Needs a short comment. Mention that this only cre
apacible 2014/11/26 22:42:50 Done.
+ content::BrowserContext* browser_context,
+ ui::WebDialogDelegate* delegate,
+ content::WebContents* overshadowed,
+ gfx::Size min_size,
+ gfx::Size max_size);
+
#endif // CHROME_BROWSER_UI_WEBUI_CONSTRAINED_WEB_DIALOG_UI_H_

Powered by Google App Engine
This is Rietveld 408576698