Enable AutoResize for Constrained Web Dialogs

chrome/browser/ui/webui/constrained_web_dialog_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_CONSTRAINED_WEB_DIALOG_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_CONSTRAINED_WEB_DIALOG_UI_H_
 
 #include "base/compiler_specific.h"
 #include "components/web_modal/native_web_contents_modal_dialog.h"
 #include "content/public/browser/web_ui_controller.h"
 #include "ui/gfx/native_widget_types.h"
+#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)

[miu, 2014/11/26 00:47:44]

Instead of including the header, just forward-declare the class (this keeps the
compiling efficient for everyone):

  namespace gfx {
    class Size;
  }

[apacible, 2014/11/26 17:35:15]

Done.

+#include "ui/gfx/size.h"
+#endif
 
 namespace content {
 class BrowserContext;
 class RenderViewHost;
 class WebContents;
 }
 
 namespace ui {
 class WebDialogDelegate;
 class WebDialogWebContentsDelegate;
@@ skipping 12 matching lines @@
   // instead of destroying it. After which point, the caller will own the
   // released WebContents.
   virtual void ReleaseWebContentsOnDialogClose() = 0;
 
   // Returns the WebContents owned by the constrained window.
   virtual content::WebContents* GetWebContents() = 0;
 
   // Returns the native type used to display the dialog.
   virtual web_modal::NativeWebContentsModalDialog GetNativeDialog() = 0;
 
+#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)

[miu, 2014/11/26 00:47:44]

This shouldn't be a part of the interface since outside callers should not
control when auto resize is enabled.  In the impl class, as mentioned above, I
think the method should be private.

[apacible, 2014/11/26 17:35:15]

Done.

+  virtual void EnableAutoResize(const gfx::Size& min_size,
+                                const gfx::Size& max_size) = 0;
+#endif
+
  protected:
   virtual ~ConstrainedWebDialogDelegate() {}
 };
 
 // ConstrainedWebDialogUI is a facility to show HTML WebUI content
 // in a tab-modal constrained dialog.  It is implemented as an adapter
 // between an WebDialogUI object and a web contents modal dialog.
 //
 // Since the web contents modal dialog requires platform-specific delegate
 // implementations, this class is just a factory stub.
@@ skipping 26 matching lines @@
 // ConstrainedWebDialogUI object.
 // |browser_context| is used to construct the constrained HTML dialog's
 //                   WebContents.
 // |delegate| controls the behavior of the dialog.
 // |overshadowed| is the tab being overshadowed by the dialog.
 ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(
     content::BrowserContext* browser_context,
     ui::WebDialogDelegate* delegate,
     content::WebContents* overshadowed);
 
+#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)

[miu, 2014/11/26 00:47:44]

Again, don't conditionally declare this function, either.  It's fine if the
function isn't implemented on Mac because there are no callers of it from any
code path that runs on Mac.  The linker will report an error should anyone try
to do this in new code.

[apacible, 2014/11/26 17:35:15]

Done.

+ConstrainedWebDialogDelegate* CreateConstrainedWebDialogWithAutoResize(
+    content::BrowserContext* browser_context,
+    ui::WebDialogDelegate* delegate,
+    content::WebContents* overshadowed,
+    gfx::Size min_size,
+    gfx::Size max_size);
+#endif
+
 #endif  // CHROME_BROWSER_UI_WEBUI_CONSTRAINED_WEB_DIALOG_UI_H_