 Chromium Code Reviews
 Chromium Code Reviews Issue 75493004:
  Spawn DBus by default as a workaround on all Linux bots.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
    
  
    Issue 75493004:
  Spawn DBus by default as a workaround on all Linux bots.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master| OLD | NEW | 
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python | 
| 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be | 
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. | 
| 5 | 5 | 
| 6 """A tool to run a chrome test executable, used by the buildbot slaves. | 6 """A tool to run a chrome test executable, used by the buildbot slaves. | 
| 7 | 7 | 
| 8 When this is run, the current directory (cwd) should be the outer build | 8 When this is run, the current directory (cwd) should be the outer build | 
| 9 directory (e.g., chrome-release/build/). | 9 directory (e.g., chrome-release/build/). | 
| 10 | 10 | 
| (...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1148 help='A file containing a JSON blob with a dict ' | 1148 help='A file containing a JSON blob with a dict ' | 
| 1149 'that will be uploaded to the results ' | 1149 'that will be uploaded to the results ' | 
| 1150 'dashboard as supplemental columns.') | 1150 'dashboard as supplemental columns.') | 
| 1151 option_parser.add_option('--enable-lsan', default=False, | 1151 option_parser.add_option('--enable-lsan', default=False, | 
| 1152 help='Enable memory leak detection (LeakSanitizer). ' | 1152 help='Enable memory leak detection (LeakSanitizer). ' | 
| 1153 'Also can be enabled with the factory ' | 1153 'Also can be enabled with the factory ' | 
| 1154 'properties "lsan" and "lsan_run_all_tests".') | 1154 'properties "lsan" and "lsan_run_all_tests".') | 
| 1155 option_parser.add_option('--extra-sharding-args', default='', | 1155 option_parser.add_option('--extra-sharding-args', default='', | 
| 1156 help='Extra options for run_test_cases.py.') | 1156 help='Extra options for run_test_cases.py.') | 
| 1157 option_parser.add_option('--spawn-dbus', action='store_true', | 1157 option_parser.add_option('--spawn-dbus', action='store_true', | 
| 1158 default=False, | 1158 default=True, | 
| 
ghost stip (do not use)
2013/11/18 23:24:33
then, if this sticks we can remove it from GPU cor
 
Ken Russell (switch to Gerrit)
2013/11/18 23:37:30
Yes. I'll take care of that if so.
 | |
| 1159 help='Work around GLib DBus bug by ' | 1159 help='Work around GLib DBus bug by ' | 
| 1160 'manually spawning dbus-launch') | 1160 'manually spawning dbus-launch') | 
| 1161 | 1161 | 
| 1162 chromium_utils.AddPropertiesOptions(option_parser) | 1162 chromium_utils.AddPropertiesOptions(option_parser) | 
| 1163 options, args = option_parser.parse_args() | 1163 options, args = option_parser.parse_args() | 
| 1164 if not options.perf_dashboard_id: | 1164 if not options.perf_dashboard_id: | 
| 1165 options.perf_dashboard_id = options.factory_properties.get('test_name') | 1165 options.perf_dashboard_id = options.factory_properties.get('test_name') | 
| 1166 | 1166 | 
| 1167 options.test_type = options.test_type or options.factory_properties.get( | 1167 options.test_type = options.test_type or options.factory_properties.get( | 
| 1168 'step_name', '') | 1168 'step_name', '') | 
| (...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1323 '%d new files were left in %s: Fix the tests to clean up themselves.' | 1323 '%d new files were left in %s: Fix the tests to clean up themselves.' | 
| 1324 ) % ((new_temp_files - temp_files), tempfile.gettempdir()) | 1324 ) % ((new_temp_files - temp_files), tempfile.gettempdir()) | 
| 1325 # TODO(maruel): Make it an error soon. Not yet since I want to iron out all | 1325 # TODO(maruel): Make it an error soon. Not yet since I want to iron out all | 
| 1326 # the remaining cases before. | 1326 # the remaining cases before. | 
| 1327 #result = 1 | 1327 #result = 1 | 
| 1328 return result | 1328 return result | 
| 1329 | 1329 | 
| 1330 | 1330 | 
| 1331 if '__main__' == __name__: | 1331 if '__main__' == __name__: | 
| 1332 sys.exit(main()) | 1332 sys.exit(main()) | 
| OLD | NEW |