Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issue 754873004: String changes on screen-share status tray item (Closed)

Created:
6 years ago by kelvinp
Modified:
6 years ago
Reviewers:
Jamie, dcaiafa
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

String changes on screen share status tray item When a Remote Assistance session is connected on Chrome OS, the status tray says, "Sharing the control of your screen via Hangouts" even when the user is only using CRD without Hangouts. This change renames the string to "Sharing the control of your screen via Remote Assistance". Remote Assistance is also the name of the Hangouts app, so it would work for both Hangouts and CRD. BUG=439590 Committed: https://crrev.com/f90eb48e05bbfe218bbe8d7137318bf33abcf746 Cr-Commit-Position: refs/heads/master@{#307120}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kelvinp
PTAL
6 years ago (2014-12-05 22:53:43 UTC) #3
Jamie
lgtm
6 years ago (2014-12-05 23:22:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754873004/20001
6 years ago (2014-12-05 23:30:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-06 00:09:34 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-06 00:30:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f90eb48e05bbfe218bbe8d7137318bf33abcf746
Cr-Commit-Position: refs/heads/master@{#307120}

Powered by Google App Engine
This is Rietveld 408576698