Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/compiler/jump-threading.cc

Issue 754843002: [turbofan] Implement jump threading after register allocation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix stupid out of bounds access in test. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/jump-threading.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "src/compiler/jump-threading.h"
6 #include "src/compiler/code-generator-impl.h"
7
8 namespace v8 {
9 namespace internal {
10 namespace compiler {
11
12 typedef BasicBlock::RpoNumber RpoNumber;
13
14 #define TRACE(x) \
15 if (FLAG_trace_turbo_jt) PrintF x
16
17 struct JumpThreadingState {
18 bool forwarded;
19 ZoneVector<RpoNumber>& result;
20 ZoneStack<RpoNumber>& stack;
21
22 void Clear(size_t count) { result.assign(count, unvisited()); }
23 void PushIfUnvisited(RpoNumber num) {
24 if (result[num.ToInt()] == unvisited()) {
25 stack.push(num);
26 result[num.ToInt()] = onstack();
27 }
28 }
29 void Forward(RpoNumber to) {
30 RpoNumber from = stack.top();
31 RpoNumber to_to = result[to.ToInt()];
32 bool pop = true;
33 if (to == from) {
34 TRACE((" xx %d\n", from.ToInt()));
35 result[from.ToInt()] = from;
36 } else if (to_to == unvisited()) {
37 TRACE((" fw %d -> %d (recurse)\n", from.ToInt(), to.ToInt()));
38 stack.push(to);
39 result[to.ToInt()] = onstack();
40 pop = false; // recurse.
41 } else if (to_to == onstack()) {
42 TRACE((" fw %d -> %d (cycle)\n", from.ToInt(), to.ToInt()));
43 result[from.ToInt()] = to; // break the cycle.
44 forwarded = true;
45 } else {
46 TRACE((" fw %d -> %d (forward)\n", from.ToInt(), to.ToInt()));
47 result[from.ToInt()] = to_to; // forward the block.
48 forwarded = true;
49 }
50 if (pop) stack.pop();
51 }
52 RpoNumber unvisited() { return RpoNumber::FromInt(-1); }
53 RpoNumber onstack() { return RpoNumber::FromInt(-2); }
54 };
55
56
57 bool JumpThreading::ComputeForwarding(Zone* local_zone,
58 ZoneVector<RpoNumber>& result,
59 InstructionSequence* code) {
60 ZoneStack<RpoNumber> stack(local_zone);
61 JumpThreadingState state = {false, result, stack};
62 state.Clear(code->InstructionBlockCount());
63
64 // Iterate over the blocks forward, pushing the blocks onto the stack.
65 for (auto const block : code->instruction_blocks()) {
66 RpoNumber current = block->rpo_number();
67 state.PushIfUnvisited(current);
68
69 // Process the stack, which implements DFS through empty blocks.
70 while (!state.stack.empty()) {
71 InstructionBlock* block = code->InstructionBlockAt(state.stack.top());
72 // Process the instructions in a block up to a non-empty instruction.
73 TRACE(("jt [%d] B%d RPO%d\n", static_cast<int>(stack.size()),
74 block->id().ToInt(), block->rpo_number().ToInt()));
75 bool fallthru = true;
76 RpoNumber fw = block->rpo_number();
77 for (int i = block->code_start(); i < block->code_end(); ++i) {
78 Instruction* instr = code->InstructionAt(i);
79 if (instr->IsGapMoves() && GapInstruction::cast(instr)->IsRedundant()) {
80 // skip redundant gap moves.
81 TRACE((" nop gap\n"));
82 continue;
83 } else if (instr->IsSourcePosition()) {
84 // skip source positions.
85 TRACE((" src pos\n"));
86 continue;
87 } else if (FlagsModeField::decode(instr->opcode()) != kFlags_none) {
88 // can't skip instructions with flags continuations.
89 TRACE((" flags\n"));
90 fallthru = false;
91 } else if (instr->IsNop()) {
92 // skip nops.
93 TRACE((" nop\n"));
94 continue;
95 } else if (instr->arch_opcode() == kArchJmp) {
96 // try to forward the jump instruction.
97 TRACE((" jmp\n"));
98 fw = code->InputRpo(instr, 0);
99 fallthru = false;
100 } else {
101 // can't skip other instructions.
102 TRACE((" other\n"));
103 fallthru = false;
104 }
105 break;
106 }
107 if (fallthru) {
108 int next = 1 + block->rpo_number().ToInt();
109 if (next < code->InstructionBlockCount()) fw = RpoNumber::FromInt(next);
110 }
111 state.Forward(fw);
112 }
113 }
114
115 #if DEBUG
116 for (RpoNumber num : result) DCHECK(num.IsValid());
117 #endif
118
119 for (int i = 0; i < static_cast<int>(result.size()); i++) {
120 TRACE(("RPO%d B%d ", i,
121 code->InstructionBlockAt(RpoNumber::FromInt(i))->id().ToInt()));
122 int to = result[i].ToInt();
123 if (i != to) {
124 TRACE(("-> B%d\n",
125 code->InstructionBlockAt(RpoNumber::FromInt(to))->id().ToInt()));
126 } else {
127 TRACE(("\n"));
128 }
129 }
130
131 return state.forwarded;
132 }
133
134
135 void JumpThreading::ApplyForwarding(ZoneVector<RpoNumber>& result,
136 InstructionSequence* code) {
137 if (!FLAG_turbo_jt) return;
138
139 Zone local_zone(code->zone()->isolate());
140 ZoneVector<bool> skip(static_cast<int>(result.size()), false, &local_zone);
141
142 // Skip empty blocks when the previous block doesn't fall through.
143 bool prev_fallthru = true;
144 for (auto const block : code->instruction_blocks()) {
145 int block_num = block->rpo_number().ToInt();
146 skip[block_num] = !prev_fallthru && result[block_num].ToInt() != block_num;
147
148 bool fallthru = true;
149 for (int i = block->code_start(); i < block->code_end(); ++i) {
150 Instruction* instr = code->InstructionAt(i);
151 if (FlagsModeField::decode(instr->opcode()) == kFlags_branch) {
152 fallthru = false; // branches don't fall through to the next block.
153 } else if (instr->arch_opcode() == kArchJmp) {
154 if (skip[block_num]) {
155 // Overwrite a redundant jump with a nop.
156 TRACE(("jt-fw nop @%d\n", i));
157 instr->OverwriteWithNop();
158 }
159 fallthru = false; // jumps don't fall through to the next block.
160 }
161 }
162 prev_fallthru = fallthru;
163 }
164
165 // Patch RPO immediates.
166 InstructionSequence::Immediates& immediates = code->immediates();
167 for (size_t i = 0; i < immediates.size(); i++) {
168 Constant constant = immediates[i];
169 if (constant.type() == Constant::kRpoNumber) {
170 RpoNumber rpo = constant.ToRpoNumber();
171 RpoNumber fw = result[rpo.ToInt()];
172 if (!(fw == rpo)) immediates[i] = Constant(fw);
173 }
174 }
175
176 // Recompute assembly order numbers.
177 int ao = 0;
178 for (auto const block : code->instruction_blocks()) {
179 if (!block->IsDeferred()) {
180 block->set_ao_number(RpoNumber::FromInt(ao));
181 if (!skip[block->rpo_number().ToInt()]) ao++;
182 }
183 }
184 for (auto const block : code->instruction_blocks()) {
185 if (block->IsDeferred()) {
186 block->set_ao_number(RpoNumber::FromInt(ao));
187 if (!skip[block->rpo_number().ToInt()]) ao++;
188 }
189 }
190 }
191
192 } // namespace compiler
193 } // namespace internal
194 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/jump-threading.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698