Cleanup res cache bench and split out into a unit test.

Cleanup res cache bench and split out into a unit test.

BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/4e4303f002c5958c6c958e7ba8e49b24c25f0b22

[bsalomon, 2014-11-24 15:36:22]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2014-11-24 15:51:53]

lgtm + a nit, a question & a suggestion

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.cpp
File bench/GrResourceCacheBench.cpp (right):

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:41: private:
rm virtual ?

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:83: for (int i = 0; i < loops; ++i) {
How is this assert not firing ?

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:120: 
Move this to onPreDraw to purify the find timing ?

[bsalomon, 2014-11-24 16:04:07]

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.cpp
File bench/GrResourceCacheBench.cpp (right):

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:41: private:
On 2014/11/24 15:51:53, robertphillips wrote:
> rm virtual ?

Done.

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:83: for (int i = 0; i < loops; ++i) {
On 2014/11/24 15:51:53, robertphillips wrote:
> How is this assert not firing ?

Oops, will move out of the loop. nanobench determines that it only needs to run
the loop once :)

https://codereview.chromium.org/754833002/diff/1/bench/GrResourceCacheBench.c...
bench/GrResourceCacheBench.cpp:120: 
On 2014/11/24 15:51:53, robertphillips wrote:
> Move this to onPreDraw to purify the find timing ?

Done and it made a huge difference.

[bsalomon, 2014-11-24 16:04:13]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-24 16:04:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754833002/20001

[bsalomon, 2014-11-24 16:05:39]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-11-24 16:06:16]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-24 16:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754833002/40001

[commit-bot: I haz the power, 2014-11-24 16:25:09]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4e4303f002c5958c6c958e7ba8e49b24c25f0b22