Revert 235801 "Fix crash when locking a profile. The crash is ha..."

Revert 235801 "Fix crash when locking a profile. The crash is ha..."

> Fix crash when locking a profile. The crash is happening because navigating to a URL triggers the signin header helper code. Since locking shouldn't actually do a Gaia logout, I'm removing all the code related to that.
> 
> NOTRY-ing because it's been a week of "extension "RANDR" missing on display ":9" bot errors. 
> 
> BUG=NONE
> TBR=pkasting@chromium.org
> NOTRY=TRUE
> 
> Review URL: https://codereview.chromium.org/64313005

TBR=noms@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235822

[dewittj, 2013-11-18 21:47:17]

Committed patchset #1 manually as r235822.

[dewittj, 2013-11-18 21:47:44]

On 2013/11/18 21:46:30, dewittj wrote:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

This error also happened in your original try run for win_rel.

[noms, 2013-11-18 21:51:51]

Eeek. Sorry about this -- I missed that amongst the other unrelated errors.
Taking a look, thanks!


On Mon, Nov 18, 2013 at 4:47 PM, <dewittj@chromium.org> wrote:

> On 2013/11/18 21:46:30, dewittj wrote:
>
> http://build.chromium.org/p/chromium.win/builders/Win7%
> 20Tests%20%28dbg%29%284%29/builds/23184
>
> This error also happened in your original try run for win_rel.
>
> https://codereview.chromium.org/75483005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dewittj, 2013-11-18 22:25:46]

BTW, this may not be you after all; I'm investigating 
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%284%...

which appears to have broken the same test but before your commit.  Let me know
in IRC or chat if you find that your code is okay (and one of the commits in the
above build is the culprit) and we'll reland yours.

[noms, 2013-11-18 22:27:06]

No worries; I think it's a flaky test.
I pushed a patch that should fix it in that same CL, though, and I will
resubmit it.


On Mon, Nov 18, 2013 at 5:25 PM, <dewittj@chromium.org> wrote:

> BTW, this may not be you after all; I'm investigating
> http://build.chromium.org/p/chromium.win/builders/XP%
> 20Tests%20%28dbg%29%284%29/builds/38313
>
> which appears to have broken the same test but before your commit.  Let me
> know
> in IRC or chat if you find that your code is okay (and one of the commits
> in the
> above build is the culprit) and we'll reland yours.
>
> https://codereview.chromium.org/75483005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.