Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 75483002: Set a base address for chrome_elf (Closed)

Created:
7 years, 1 month ago by Cait (Slow)
Modified:
4 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews
Visibility:
Public.

Description

Set a base address for chrome_elf to avoid base address collisions with chrome_dll. NOTRY=true BUG=318691 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -25 lines) Patch
M chrome_elf/chrome_elf.gyp View 1 chunk +32 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cait (Slow)
7 years, 1 month ago (2013-11-18 18:27:15 UTC) #1
robertshield
LGTM, please double check that this fixes the problem on XP.
7 years, 1 month ago (2013-11-18 18:28:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/75483002/1
7 years, 1 month ago (2013-11-18 22:50:01 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 22:55:56 UTC) #4
Message was sent while issue was closed.
Change committed as 235835

Powered by Google App Engine
This is Rietveld 408576698