chrome/test/functional/extensions.py - Issue 7548024: Refactor: Make PyAuto InstallExtension() take a string. Delete dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/extensions.py

Issue 7548024: Refactor: Make PyAuto InstallExtension() take a string. Delete dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup per kkania. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/functional/extensions.py

diff --git a/chrome/test/functional/extensions.py b/chrome/test/functional/extensions.py

index 8a40848e2927e2ac239722079069511b6c015ad1..133210152276bb143e32d6987909df4cf161a55f 100644

--- a/chrome/test/functional/extensions.py

+++ b/chrome/test/functional/extensions.py

@@ -64,7 +64,7 @@ class ExtensionsTest(pyauto.PyUITest):

group_end = curr_extension + group_size

for extension in extensions[curr_extension:group_end]:

logging.debug('Installing extension: %s' % extension)

- self.InstallExtension(pyauto.FilePath(extension), False)

+ self.InstallExtension(extension, False)

for url in top_urls:

self.NavigateToURL(url)

@@ -157,7 +157,7 @@ class ExtensionsTest(pyauto.PyUITest):

"""Test setting different extension states."""

crx_file_path = os.path.abspath(

os.path.join(self.DataDir(), 'extensions', 'google_talk.crx'))

- ext_id = self.InstallExtension(pyauto.FilePath(crx_file_path), False);

+ ext_id = self.InstallExtension(crx_file_path, False);

self.assertTrue(ext_id, 'Failed to install extension.')

# Verify extension is in default state.

« no previous file with comments | « chrome/test/functional/chromeos_security.py ('k') | chrome/test/functional/memory.py » ('j') | no next file with comments »