Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 7548016: Merge 92143 - .: REGRESSION (r39725?): Resources removed from document can not be freed until the... (Closed)

Created:
7 years, 10 months ago by James Simonsen
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92143 - .: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted https://bugs.webkit.org/show_bug.cgi?id=61006 Patch by Scott Graham <scottmg@chromium.org>; on 2011-08-01 Reviewed by Antti Koivisto. Update exports for test harness. * Source/autotools/symbols.filter: Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted https://bugs.webkit.org/show_bug.cgi?id=61006 Patch by Scott Graham <scottmg@chromium.org>; on 2011-08-01 Reviewed by Antti Koivisto. Upon completing a load start a Timer to iterate through CachedResourceLoader's m_documentResources map to check for any items that have only one reference (thus being the reference in the map itself). The map should really be weak, but because the CachedResourceHandle achieves bookkeeping work in addition to reference counting, this is a simpler and more localized way to free the used memory while maintaining the other behaviour (when CachedResource is used as proxy). With this patch the testcase at https://bugs.webkit.org/attachment.cgi?id=93850 should no longer consume 400MB of ram on load. Test added for crash discovered in previous revision, but no tests for memory usage. Test: http/tests/inspector/network/disabled-cache-crash.html * WebCore.exp.in: * loader/cache/CachedResource.h: (WebCore::CachedResource::hasOneHandle): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::loadDone): (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired): * loader/cache/CachedResourceLoader.h: * testing/Internals.cpp: (WebCore::Internals::disableMemoryCache): * testing/Internals.h: * testing/Internals.idl: Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted https://bugs.webkit.org/show_bug.cgi?id=61006 Patch by Scott Graham <scottmg@chromium.org>; on 2011-08-01 Reviewed by Antti Koivisto. Update exports for test harness. * win/WebKit2.def: * win/WebKit2CFLite.def: LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006 Test for CachedResourceLoader. Not caused by cache-disabling but very difficult to reproduce when cache is active, so use cache disable in inspector to exercise code. Patch by Scott Graham <scottmg@chromium.org>; on 2011-08-01 Reviewed by Antti Koivisto. * http/tests/inspector/network/disabled-cache-crash-expected.txt: Added. * http/tests/inspector/network/disabled-cache-crash.html: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5865 lines, --2 lines) Patch
M ChangeLog View 1 chunk +75 lines, -0 lines 0 comments Download
M LayoutTests/ChangeLog View 2 chunks +1980 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/inspector/network/disabled-cache-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/network/disabled-cache-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/gtk/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +3165 lines, -0 lines 0 comments Download
M Source/WebCore/WebCore.exp.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResourceLoader.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResourceLoader.cpp View 2 chunks +28 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit2/ChangeLog View 1 chunk +595 lines, -0 lines 0 comments Download
M Source/WebKit2/win/WebKit2.def View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit2/win/WebKit2CFLite.def View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/autotools/symbols.filter View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Simonsen
7 years, 10 months ago (2011-08-02 17:36:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698