Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: ash/sticky_keys/sticky_keys_overlay.h

Issue 754763005: Speculative fix for sticky keys overlay crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/sticky_keys/sticky_keys_overlay.h
diff --git a/ash/sticky_keys/sticky_keys_overlay.h b/ash/sticky_keys/sticky_keys_overlay.h
index 63917941a4c4bfe872d9b88ca35efa0bc5f69513..a257b0d215307cbecebb160a1f769a8b5b87f4e0 100644
--- a/ash/sticky_keys/sticky_keys_overlay.h
+++ b/ash/sticky_keys/sticky_keys_overlay.h
@@ -61,9 +61,10 @@ class ASH_EXPORT StickyKeysOverlay : public ui::LayerAnimationObserver {
void OnLayerAnimationScheduled(ui::LayerAnimationSequence* sequence) override;
bool is_visible_;
+ // Note: keep the order the same. |overlay_view_| must outlive
+ // |overlay_widget_|.
+ scoped_ptr<StickyKeysOverlayView> overlay_view_;
scoped_ptr<views::Widget> overlay_widget_;
- // Ownership of |overlay_view_| is passed to the view heirarchy.
- StickyKeysOverlayView* overlay_view_;
gfx::Size widget_size_;
};

Powered by Google App Engine
This is Rietveld 408576698