Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: ash/sticky_keys/sticky_keys_overlay.h

Issue 754763005: Speculative fix for sticky keys overlay crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/sticky_keys/sticky_keys_overlay.h
diff --git a/ash/sticky_keys/sticky_keys_overlay.h b/ash/sticky_keys/sticky_keys_overlay.h
index 63917941a4c4bfe872d9b88ca35efa0bc5f69513..8fdb9ed3eeeb39145e52c908d62e23ec1c4d3553 100644
--- a/ash/sticky_keys/sticky_keys_overlay.h
+++ b/ash/sticky_keys/sticky_keys_overlay.h
@@ -51,6 +51,10 @@ class ASH_EXPORT StickyKeysOverlay : public ui::LayerAnimationObserver {
// animating, the returned value is the target of the animation.
bool is_visible() { return is_visible_; }
+ // Returns the underlying ::views Widget for testing purposes. The returned
James Cook 2014/12/01 21:06:00 nit: views::Widget
Tim Song 2014/12/02 20:07:05 Done.
+ // widget is owned by StickyKeysOverlay.
James Cook 2014/12/01 21:06:00 Thanks for an ownership comment!
+ views::Widget* GetWidgetForTesting();
+
private:
// Returns the current bounds of the overlay, which is based on visibility.
gfx::Rect CalculateOverlayBounds();
@@ -62,7 +66,7 @@ class ASH_EXPORT StickyKeysOverlay : public ui::LayerAnimationObserver {
bool is_visible_;
scoped_ptr<views::Widget> overlay_widget_;
- // Ownership of |overlay_view_| is passed to the view heirarchy.
+ // The |overlay_view_| will be owned by |overlay_widget_|.
StickyKeysOverlayView* overlay_view_;
gfx::Size widget_size_;
};
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_overlay.cc » ('j') | ash/sticky_keys/sticky_keys_overlay_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698