Speculative fix for sticky keys overlay crash.

ash/sticky_keys/sticky_keys_overlay.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_STICKY_KEYS_STICKY_KEYS_OVERLAY_H_
 #define ASH_STICKY_KEYS_STICKY_KEYS_OVERLAY_H_
 
 #include "ash/ash_export.h"
 #include "ash/sticky_keys/sticky_keys_state.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 33 matching lines @@
   void SetModifierKeyState(ui::EventFlags modifier,
                            StickyKeyState state);
 
   // Get the current state of the sticky key modifier in the overlay.
   StickyKeyState GetModifierKeyState(ui::EventFlags modifier);
 
   // Returns true if the overlay is currently visible. If the overlay is
   // animating, the returned value is the target of the animation.
   bool is_visible() { return is_visible_; }
 
+  // Returns the underlying views::Widget for testing purposes. The returned
+  // widget is owned by StickyKeysOverlay.
+  views::Widget* GetWidgetForTesting();
+
  private:
   // Returns the current bounds of the overlay, which is based on visibility.
   gfx::Rect CalculateOverlayBounds();
 
   // gfx::LayerAnimationObserver overrides:
   void OnLayerAnimationEnded(ui::LayerAnimationSequence* sequence) override;
   void OnLayerAnimationAborted(ui::LayerAnimationSequence* sequence) override;
   void OnLayerAnimationScheduled(ui::LayerAnimationSequence* sequence) override;
 
   bool is_visible_;
+  // Note: keep the order the same. |overlay_view_| must outlive
+  // |overlay_widget_|.
+  scoped_ptr<StickyKeysOverlayView> overlay_view_;

[Jun Mukai, 2014/12/04 21:58:55]

Why it must outlive?

[Tim Song, 2014/12/04 23:53:37]

Done. This is no longer needed after getting rid of the WidgetDelegate.

   scoped_ptr<views::Widget> overlay_widget_;
-  // Ownership of |overlay_view_| is passed to the view heirarchy.
-  StickyKeysOverlayView* overlay_view_;
   gfx::Size widget_size_;
 };
 
 }  // namespace ash
 
 #endif  // ASH_STICKY_KEYS_STICKY_KEYS_OVERLAY_H_