Speculative fix for sticky keys overlay crash.

ash/sticky_keys/sticky_keys_overlay_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/sticky_keys/sticky_keys_overlay.h"
 
 #include "ash/shell.h"
 #include "ash/sticky_keys/sticky_keys_controller.h"
 #include "ash/test/ash_test_base.h"
 #include "ui/events/event.h"
+#include "ui/views/widget/widget.h"
 
 namespace ash {
 
 class StickyKeysOverlayTest : public test::AshTestBase {

[James Cook, 2014/12/01 21:06:00]

optional: This could become:

using StickyKeysOverlayTest = test::AshTestBase;

and no functions.

[Tim Song, 2014/12/02 20:07:05]

Done.

  public:
   StickyKeysOverlayTest() {}
   virtual ~StickyKeysOverlayTest() {}
 };
 
 TEST_F(StickyKeysOverlayTest, OverlayVisibility) {
   StickyKeysOverlay overlay;
   EXPECT_FALSE(overlay.is_visible());
   overlay.Show(true);
   EXPECT_TRUE(overlay.is_visible());
 }
 
 TEST_F(StickyKeysOverlayTest, ModifierKeyState) {
   StickyKeysOverlay overlay;
   overlay.SetModifierKeyState(ui::EF_SHIFT_DOWN, STICKY_KEY_STATE_DISABLED);
   overlay.SetModifierKeyState(ui::EF_ALT_DOWN, STICKY_KEY_STATE_LOCKED);
   overlay.SetModifierKeyState(ui::EF_CONTROL_DOWN, STICKY_KEY_STATE_ENABLED);
   overlay.SetModifierKeyState(ui::EF_COMMAND_DOWN, STICKY_KEY_STATE_LOCKED);
 
   EXPECT_EQ(STICKY_KEY_STATE_DISABLED,
             overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN));
   EXPECT_EQ(STICKY_KEY_STATE_LOCKED,
             overlay.GetModifierKeyState(ui::EF_ALT_DOWN));
   EXPECT_EQ(STICKY_KEY_STATE_ENABLED,
             overlay.GetModifierKeyState(ui::EF_CONTROL_DOWN));
   EXPECT_EQ(STICKY_KEY_STATE_LOCKED,
             overlay.GetModifierKeyState(ui::EF_COMMAND_DOWN));
 }
 
+TEST_F(StickyKeysOverlayTest, OverlayViewOwnership) {

[James Cook, 2014/12/01 21:06:00]

nit: Document what this test is testing. I like to include a link to the crbug
for things testing a crash or specific issue.

[Tim Song, 2014/12/02 20:07:05]

Done.

+  StickyKeysOverlay overlay;
+  views::Widget* widget = overlay.GetWidgetForTesting();
+  ASSERT_TRUE(widget);
+  delete widget->GetNativeWindow();
+
+  // States should still be valid even after the native window associated with
+  // the Widget is destroyed.
+  overlay.SetModifierKeyState(ui::EF_SHIFT_DOWN, STICKY_KEY_STATE_ENABLED);
+  EXPECT_EQ(STICKY_KEY_STATE_ENABLED,
+            overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN));
+  overlay.SetModifierKeyState(ui::EF_SHIFT_DOWN, STICKY_KEY_STATE_DISABLED);
+  EXPECT_EQ(STICKY_KEY_STATE_DISABLED,
+            overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN));
+}
+
 // Additional sticky key overlay tests that depend on chromeos::EventRewriter
 // are now in chrome/browser/chromeos/events/event_rewriter_unittest.cc .
 
 }  // namespace ash