Source/core/rendering/style/RenderStyle.cpp - Issue 754743004: Don't return false for RenderStyle::operator== while fonts load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 754743004: Don't return false for RenderStyle::operator== while fonts load. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed review issue and regressions. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 44183b6f552cd27d76e54375145e2bd8bc029880..a78996704b7d0b7d1a9e550f80a9aeabedd55631 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -508,6 +508,9 @@ bool RenderStyle::diffNeedsFullLayoutAndPaintInvalidation(const RenderStyle& oth

if (inherited->textAutosizingMultiplier != other.inherited->textAutosizingMultiplier)

return true;

+ if (inherited->font.loadingCustomFonts() != other.inherited->font.loadingCustomFonts())

+ return true;

if (inherited.get() != other.inherited.get()) {

if (inherited->line_height != other.inherited->line_height

|| inherited->font != other.inherited->font