Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 754743003: Modify big integer library (Closed)

Created:
6 years ago by Bo Xu
Modified:
6 years ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Modify big integer library This patch follows https://pdfium.googlesource.com/pdfium/+/44047c3300d07192a67b1714084cc2d43b1e9bd9 Modify the library to resolve compile error, add copyright notice and change pdfium.gyp and BUILD.gn R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/91dd8c77ae849c22a8e4c9275e3f728b474b5be5

Patch Set 1 #

Patch Set 2 : Rebase after bigint checkin #

Patch Set 3 : Add copyright notice #

Total comments: 3

Patch Set 4 : Add . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -13 lines) Patch
M BUILD.gn View 2 chunks +16 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/bigint/BigInteger.cc View 1 2 3 9 chunks +38 lines, -0 lines 0 comments Download
M third_party/bigint/BigInteger.hh View 1 2 3 4 chunks +30 lines, -4 lines 0 comments Download
M third_party/bigint/BigIntegerLibrary.hh View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M third_party/bigint/BigIntegerUtils.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/bigint/BigIntegerUtils.hh View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/bigint/BigUnsigned.cc View 1 2 3 7 chunks +30 lines, -0 lines 0 comments Download
M third_party/bigint/BigUnsigned.hh View 1 2 3 8 chunks +44 lines, -6 lines 0 comments Download
M third_party/bigint/BigUnsignedInABase.cc View 1 2 3 4 chunks +34 lines, -0 lines 0 comments Download
M third_party/bigint/BigUnsignedInABase.hh View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/bigint/NumberlikeArray.hh View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Bo Xu
Hi Tom, please review the CL. We need the BigUnsigned type and the BigIntegerUtils which ...
6 years ago (2014-11-26 01:26:54 UTC) #2
Tom Sepez
> The copyright notice would be another concern. The author has waived the > copyright, ...
6 years ago (2014-12-01 18:06:33 UTC) #3
Bo Xu
On 2014/12/01 18:06:33, Tom Sepez wrote: > > The copyright notice would be another concern. ...
6 years ago (2014-12-01 18:30:21 UTC) #4
Bo Xu
Tom, this patch is the third in the row. Please take a look at the ...
6 years ago (2014-12-02 23:43:40 UTC) #5
Tom Sepez
lgtm https://codereview.chromium.org/754743003/diff/40001/third_party/bigint/BigInteger.cc File third_party/bigint/BigInteger.cc (right): https://codereview.chromium.org/754743003/diff/40001/third_party/bigint/BigInteger.cc#newcode5 third_party/bigint/BigInteger.cc:5: // Original code by Matt McCutchen, see the ...
6 years ago (2014-12-03 00:14:19 UTC) #6
Bo Xu
https://codereview.chromium.org/754743003/diff/40001/third_party/bigint/BigUnsigned.hh File third_party/bigint/BigUnsigned.hh (right): https://codereview.chromium.org/754743003/diff/40001/third_party/bigint/BigUnsigned.hh#newcode93 third_party/bigint/BigUnsigned.hh:93: using NumberlikeArray<Blk>::getCapacity; On 2014/12/03 00:14:19, Tom Sepez wrote: > ...
6 years ago (2014-12-03 00:31:22 UTC) #7
Bo Xu
6 years ago (2014-12-03 00:35:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
91dd8c77ae849c22a8e4c9275e3f728b474b5be5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698