Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 754693004: Cleanup: remove the namespace-level nodoc annotations from Extension API (Closed)

Created:
6 years ago by not at google - send to devlin
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove the namespace-level nodoc annotations from Extension API schemas. They're unnecessary (controlled by the presence, or lack thereof, of an HTML file documenting the API) and I keep on seeing code reviews of cargo-culted APIs that add it. R=rockot@chromium.org Committed: https://crrev.com/b735be2e5de50ec5a973be5662aa7415c96c77ad Cr-Commit-Position: refs/heads/master@{#307068}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
(and I checked to make sure there aren't HTML files added for these already, so, ...
6 years ago (2014-12-05 19:20:26 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years ago (2014-12-05 19:25:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754693004/1
6 years ago (2014-12-05 19:27:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 20:13:32 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 20:14:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b735be2e5de50ec5a973be5662aa7415c96c77ad
Cr-Commit-Position: refs/heads/master@{#307068}

Powered by Google App Engine
This is Rietveld 408576698