Matching of top-level functions, methods and accessors.

pkg/analyzer/lib/src/generated/incremental_resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver;
 
 import 'dart:collection';
 
 import 'ast.dart';
 import 'element.dart';
@@ skipping 182 matching lines @@
     _enclosingFieldNode = node;
     try {
       super.visitFieldDeclaration(node);
     } finally {
       _enclosingFieldNode = null;
     }
   }
 
   @override
   visitFunctionDeclaration(FunctionDeclaration node) {
+    // prepare element name
     String name = node.name.name;
+    if (node.isSetter) {
+      name += '=';
+    }
+    // prepare element
     Token property = node.propertyKeyword;
     ExecutableElement element;
     if (property == null) {
       element = _findElement(_enclosingUnit.functions, name);
-      _processElement(element);
     } else {
-      PropertyAccessorElement accessor =
-          _findElement(_enclosingUnit.accessors, name);
-      _assertNotNull(accessor);
-      _assertFalse(element.isSynthetic);
-      _assertEquals(node.isGetter, accessor.isGetter);
-      _assertEquals(node.isSetter, accessor.isSetter);
-      element = accessor;
+      element = _findElement(_enclosingUnit.accessors, name);
     }
+    // process element
     _processElement(element);
-    // TODO(scheglov) test returnType
+    _assertFalse(element.isSynthetic);
     _assertSameType(node.returnType, element.returnType);
     _assertCompatibleParameters(
         node.functionExpression.parameters,
         element.parameters);
   }
 
   @override
   visitFunctionTypeAlias(FunctionTypeAlias node) {
     FunctionTypeAliasElement outerAlias = _enclosingAlias;
     try {
@@ skipping 42 matching lines @@
     if (name == TokenType.MINUS.lexeme &&
         node.parameters.parameters.length == 0) {
       name = "unary-";
     }
     // prepare element
     Token property = node.propertyKeyword;
     ExecutableElement element;
     if (property == null) {
       element = _findElement(_enclosingClass.methods, name);
     } else {
-      PropertyAccessorElement accessor =
-          _findElement(_enclosingClass.accessors, name);
-      _assertNotNull(accessor);
-      _assertFalse(element.isSynthetic);
-      _assertEquals(node.isGetter, accessor.isGetter);
-      _assertEquals(node.isSetter, accessor.isSetter);
-      element = accessor;
+      element = _findElement(_enclosingClass.accessors, name);
     }
     // process element
     _processElement(element);
-    // TODO(scheglov) test returnType
+    _assertFalse(element.isSynthetic);
+    _assertEquals(node.isStatic, element.isStatic);
     _assertSameType(node.returnType, element.returnType);
     _assertCompatibleParameters(node.parameters, element.parameters);
   }
 
   @override
   visitPartDirective(PartDirective node) {
     String uri = _getStringValue(node.uri);
     if (uri != null) {
       CompilationUnitElement element =
           _findUriReferencedElement(_enclosingLibrary.parts, uri);
@@ skipping 91 matching lines @@
       _assertSameType(node.type, element.type);
     } else {
       // TODO(scheglov) support other parameter types
       _assertTrue(false);
     }
     // TODO(scheglov) check names of named parameters
   }
 
   void _assertCompatibleParameters(FormalParameterList nodes,
       List<ParameterElement> elements) {
+    if (nodes == null) {
+      return _assertEquals(elements.length, 0);
+    }
     List<FormalParameter> parameters = nodes.parameters;
     int length = parameters.length;
     _assertEquals(length, elements.length);
     for (int i = 0; i < length; i++) {
       _assertCompatibleParameter(parameters[i], elements[i]);
     }
   }
 
   void _assertEquals(Object a, Object b) {
     if (a != b) {
@@ skipping 86 matching lines @@
       }
       parent = parent.enclosingElement;
     }
   }
 
   /**
    * Return the [Element] in [elements] with the given [name].
    */
   Element _findElement(List<Element> elements, String name) {
     for (Element element in elements) {
-      if (element.displayName == name) {
+      if (element.name == name) {
         return element;
       }
     }
     return null;
   }
 
   /**
    * Return the element in the given array of elements that was created for the declaration with the
    * given name.
    *
@@ skipping 552 matching lines @@
   visitFunctionExpression(FunctionExpression node) {
     _elements[node] = node.element;
     super.visitFunctionExpression(node);
   }
 
   @override
   visitSimpleIdentifier(SimpleIdentifier node) {
     _elements[node] = node.staticElement;
   }
 }