Add gpu support for Apple specific 'Vertex Arrays' functions

Add gpu support for Apple specific 'Vertex Arrays' functions

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc

[paraboul, 2014-11-23 20:32:05]

paraboul@gmail.com changed reviewers:
+ bsalomon@google.com

[paraboul, 2014-11-23 20:33:31]

note : I forgot to add my name to the AUTHORS file.
Anthony Catel <paraboul@gmail.com>

[bsalomon, 2014-11-24 14:14:01]

lgtm, but don't we need to add a check in GrGLCaps.cpp to look for the APPLE
extension string (around line 237) in order to take advantage of it?

[paraboul, 2014-11-24 14:42:41]

Check for 'GL_APPLE_vertex_array_object' support in GrGLCaps

[bsalomon, 2014-11-24 14:49:20]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2014-11-24 14:49:20]

lgtm

[paraboul, 2014-11-24 14:49:48]

The CQ bit was unchecked by paraboul@gmail.com

[paraboul, 2014-11-24 14:49:49]

The CQ bit was checked by paraboul@gmail.com

[commit-bot: I haz the power, 2014-11-24 14:50:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754653002/20001

[commit-bot: I haz the power, 2014-11-24 15:05:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc

[Tom Hudson, 2014-11-24 17:58:38]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/750973003/ by tomhudson@chromium.org.

The reason for reverting is: Suspected in DM crashes, e.g.

2033 tasks left	 344M peak	  843ms	tabl-cuteoverload_skp
Signal 11:
_sigtramp (+0x1a)
create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
skiatest::Test::run() (+0x7c)
DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
DM::GpuTask::run(GrContextFactory*) (+0xa6)
DM::TaskRunner::wait() (+0x7f)
dm_main() (+0x33f)
main (+0x27)


On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and
-{Debug,Release}):

http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeFo...
.

[paraboul, 2014-11-24 18:34:24]

On 2014/11/24 17:58:38, Tom Hudson wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/750973003/ by mailto:tomhudson@chromium.org.
> 
> The reason for reverting is: Suspected in DM crashes, e.g.
> 
> 2033 tasks left	 344M peak	  843ms	tabl-cuteoverload_skp
> Signal 11:
> _sigtramp (+0x1a)
> create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
> test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
> skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
> skiatest::Test::run() (+0x7c)
> DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
> DM::GpuTask::run(GrContextFactory*) (+0xa6)
> DM::TaskRunner::wait() (+0x7f)
> dm_main() (+0x33f)
> main (+0x27)
> 
> 
> On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and
> -{Debug,Release}):
> 
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeFo...
> .

Are you sure it's related to this patch? Seems like it's still failing :
http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeFo...
Though it's my first patch and I'm not familiar with the builders.

[bsalomon, 2014-11-24 18:40:56]

On 2014/11/24 18:34:24, paraboul wrote:
> On 2014/11/24 17:58:38, Tom Hudson wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/750973003/ by mailto:tomhudson@chromium.org.
> > 
> > The reason for reverting is: Suspected in DM crashes, e.g.
> > 
> > 2033 tasks left	 344M peak	  843ms	tabl-cuteoverload_skp
> > Signal 11:
> > _sigtramp (+0x1a)
> > create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
> > test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
> > skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
> > skiatest::Test::run() (+0x7c)
> > DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
> > DM::GpuTask::run(GrContextFactory*) (+0xa6)
> > DM::TaskRunner::wait() (+0x7f)
> > dm_main() (+0x33f)
> > main (+0x27)
> > 
> > 
> > On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and
> > -{Debug,Release}):
> > 
> >
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeFo...
> > .
> 
> Are you sure it's related to this patch? Seems like it's still failing :
>
http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeFo...
> Though it's my first patch and I'm not familiar with the builders.

I agree that it is not yours. It seemed likely because both the patch and
crashes were Mac-specific. It was probably due to one of my CLs.
Investigating...