Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 754623004: clang: Suppress a -Wstring-conversion warnings in nspr. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang: Suppress a -Wstring-conversion warnings in nspr. Do the gn version directly, and roll the nss dep to pick up the gyp version. BUG=82385 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/109b55f5bed033a46f10fd2f50093b82f03586f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
6 years ago (2014-11-25 21:42:19 UTC) #2
hans
lgtm
6 years ago (2014-11-25 21:45:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754623004/1
6 years ago (2014-11-25 21:47:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/109b55f5bed033a46f10fd2f50093b82f03586f3 Cr-Commit-Position: refs/heads/master@{#305703}
6 years ago (2014-11-25 22:02:43 UTC) #6
Nico
Committed patchset #1 (id:1) manually as 109b55f5bed033a46f10fd2f50093b82f03586f3 (presubmit successful).
6 years ago (2014-11-25 22:02:51 UTC) #7
vrk (LEFT CHROMIUM)
6 years ago (2014-11-26 00:46:34 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/758303002/ by vrk@chromium.org.

The reason for reverting is: Build failed:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...
"ERROR: Shared library dependencies changed!"

Unsure if this is the cause, but it looks like a clang roll a few weeks ago
caused a similar error message (crbug.com/433065) so seeing if a revert fixes
things :) sorry if this is the wrong CL!.

Powered by Google App Engine
This is Rietveld 408576698