Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 754563004: Revert of QUIC - Android - small experiment to flush http_server_properties (Closed)

Created:
6 years ago by ramant (doing other things)
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Android - small experiment to flush http_server_properties (patchset #1 id:1 of https://codereview.chromium.org/667473003/) Reason for revert: We have found out that this change is not needed. When QUIC enabled experiment is used, we are persisting Alternate Protocol information properly (we don't see high percentage of missing alternate protocols). Original issue's description: > QUIC - Android - small experiment to flush http_server_properties > changes to disk every 500ms instead of 5secs. We are hoping if QUIC is > used as an alternate protocol, we will persist that information to disk > quicker. Hopefully, this would improve the QUIC winning the alternate > protocol race. > > R=rch@chromium.org > > Committed: https://crrev.com/708a3ef67431831c2a29aa35202fa446011020b4 > Cr-Commit-Position: refs/heads/master@{#300318} TBR=rch@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/12f64b224603b19e3c156ed471fcee3cc879e8a4 Cr-Commit-Position: refs/heads/master@{#305754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M net/http/http_server_properties_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Created Revert of QUIC - Android - small experiment to flush http_server_properties
6 years ago (2014-11-26 01:44:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754563004/1
6 years ago (2014-11-26 01:45:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-26 01:46:35 UTC) #3
commit-bot: I haz the power
6 years ago (2014-11-26 01:47:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12f64b224603b19e3c156ed471fcee3cc879e8a4
Cr-Commit-Position: refs/heads/master@{#305754}

Powered by Google App Engine
This is Rietveld 408576698