src/pathops/SkOpAngle.cpp - Issue 75453003: optimize pathops coverage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkOpAngle.cpp

Issue 75453003: optimize pathops coverage (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: remove unused code now that testing is complete Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkOpAngle.cpp

diff --git a/src/pathops/SkOpAngle.cpp b/src/pathops/SkOpAngle.cpp

index 4144add6fb2008da91a058fe9e4ede7376a513df..83ca55c4fea2e265f061719a00ac0f7bf53f0a87 100644

--- a/src/pathops/SkOpAngle.cpp

+++ b/src/pathops/SkOpAngle.cpp

@@ -108,7 +108,9 @@ bool SkOpAngle::operator<(const SkOpAngle& rh) const { // this/lh: left-hand; r

}

// see if either curve can be lengthened before trying the tangent

if (fSegment->other(fEnd) != rh.fSegment // tangents not absolutely identical

- && rh.fSegment->other(rh.fEnd) != fSegment) { // and not intersecting

+ && rh.fSegment->other(rh.fEnd) != fSegment

+ && y != -DBL_EPSILON

+ && ry != -DBL_EPSILON) { // and not intersecting

SkOpAngle longer = *this;

SkOpAngle rhLonger = rh;

if ((longer.lengthen(rh) | rhLonger.lengthen(*this)) // lengthen both