Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 754483002: Speculative windows fix after 5aa6dbdccf1950daf0cd3014bf763f35899bccf9 (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
jam
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Speculative windows fix after 5aa6dbdccf1950daf0cd3014bf763f35899bccf9 Compile error is: FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:external_application_unittests.exe /PDB:external_application_unittests.exe.pdb @external_application_unittests.exe.rsp application.application_impl.obj : error LNK2019: unresolved external symbol "public: static void __cdecl mojo::ApplicationImpl::Terminate(void)" (?Terminate@ApplicationImpl@mojo@@SAXXZ) referenced in function "private: void __cdecl mojo::ApplicationImpl::OnShellError(void)" (?OnShellError@ApplicationImpl@mojo@@AEAAXXZ) external_application_unittests.exe : fatal error LNK1120: 1 unresolved externals I suspect this is because //mojo/shell:external_application_unittests is not declaring a dependency on //mojo/application, so it's not linking in the chromium implementations of the mojo::ApplicationImpl lifetime methods. It's not clear to me why this patch changed things and not a600ca5310a2b0766dd9b000abd058520caf9fdf TBR=jam@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/31c8720743585fe1ddd12bf27c3d3022efc6848a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
John - gonna try this to fix the windows build. If it doesn't work I'll ...
6 years, 1 month ago (2014-11-22 00:20:20 UTC) #1
jamesr
Committed patchset #1 (id:1) manually as 31c8720743585fe1ddd12bf27c3d3022efc6848a (presubmit successful).
6 years, 1 month ago (2014-11-22 00:21:37 UTC) #2
jamesr
6 years, 1 month ago (2014-11-22 00:59:36 UTC) #3
Message was sent while issue was closed.
This did green up the build:

http://build.chromium.org/p/client.mojo/builders/Mojo%20Win%20%28dbg%29/build...

Powered by Google App Engine
This is Rietveld 408576698