Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 754473004: Remove implicit conversion from scoped_refptr<T> to T* in media (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversion from scoped_refptr<T> to T* in media BUG=110610 Committed: https://crrev.com/381dc3fd5b9f081203e55c2e01ab32a1d70c0711 Cr-Commit-Position: refs/heads/master@{#305368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/win/sink_filter_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
6 years, 1 month ago (2014-11-22 05:36:45 UTC) #2
xhwang
lgtm
6 years, 1 month ago (2014-11-22 06:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754473004/1
6 years, 1 month ago (2014-11-22 06:29:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/78354)
6 years, 1 month ago (2014-11-22 07:40:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754473004/1
6 years, 1 month ago (2014-11-22 17:40:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 18:24:01 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 18:24:46 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/381dc3fd5b9f081203e55c2e01ab32a1d70c0711
Cr-Commit-Position: refs/heads/master@{#305368}

Powered by Google App Engine
This is Rietveld 408576698