[Extensions Toolbar Mac] More cleanup of BrowserActionsController

[Extensions Toolbar Mac] More cleanup of BrowserActionsController

* Make all shouldAnimate checks use the ToolbarActionsBar.
* Simplify kBrowserActionGrippyDragFinishedNotification.
* Move a Redraw/Resize into ToolbarActionsBar::CreateActions().
* Remove unused params/functions.

BUG=429810
Committed: https://crrev.com/9c71c6fd748d4a4a1747e4d8d67940689e52b4f7
Cr-Commit-Position: refs/heads/master@{#305531}

[Devlin, 2014-11-24 19:23:05]

Patchset #1 (id:1) has been deleted

[Devlin, 2014-11-24 21:20:53]

Patchset #1 (id:20001) has been deleted

[Devlin, 2014-11-24 21:30:05]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org, sky@chromium.org

[Devlin, 2014-11-24 21:30:05]

Please take a look when you can.
Avi - cocoa.
Scott - ui/toolbar, ui/views/toolbar.

Cheers!

[Avi (use Gerrit), 2014-11-24 21:37:23]

Cocoa stuff LGTM.

[sky, 2014-11-24 21:54:43]

https://codereview.chromium.org/754473003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/browser_actions_container.cc (right):

https://codereview.chromium.org/754473003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/browser_actions_container.cc:726: if
(!toolbar_actions_bar_->enabled())
Is it possible this is added when toolbar_actions_bar_isn't enabled and then
toolbar_actions_bar_ is enabled?

[Devlin, 2014-11-24 22:00:28]

https://codereview.chromium.org/754473003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/browser_actions_container.cc (right):

https://codereview.chromium.org/754473003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/browser_actions_container.cc:726: if
(!toolbar_actions_bar_->enabled())
On 2014/11/24 21:54:43, sky wrote:
> Is it possible this is added when toolbar_actions_bar_isn't enabled and then
> toolbar_actions_bar_ is enabled?

Nope.  ToolbarActionsBar::enabled() corresponds to the presence of an
ExtensionToolbarModel - which is only null in unittests.  If there is, or should
ever be, anything in the browser actions container, then enabled() will be true
from construction.

[sky, 2014-11-24 22:06:23]

Ok, LGTM

[Devlin, 2014-11-24 22:08:29]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-11-24 22:09:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754473003/40001

[commit-bot: I haz the power, 2014-11-25 00:25:20]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2014-11-25 00:25:56]

Patchset 1 (id:??) landed as
https://crrev.com/9c71c6fd748d4a4a1747e4d8d67940689e52b4f7
Cr-Commit-Position: refs/heads/master@{#305531}