Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 754463003: Fix race condition in test (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
rafaelw
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix race condition in test The |done| function comes from |it| not |describe|. Previously, we were just ending the test right away. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1b66075e3c40be3df583d86824f722e1e83734f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sky/tests/editing/delete_block_contents.sky View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-21 23:43:55 UTC) #2
rafaelw
lgtm
6 years, 1 month ago (2014-11-21 23:49:20 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-22 00:08:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b66075e3c40be3df583d86824f722e1e83734f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698