Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: pkg/source_span/lib/src/span_mixin.dart

Issue 754463002: Avoid instantiating FileLocations where possible in source_span. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library source_span.span_mixin; 5 library source_span.span_mixin;
6 6
7 import 'package:path/path.dart' as p; 7 import 'package:path/path.dart' as p;
8 8
9 import 'colors.dart' as colors; 9 import 'colors.dart' as colors;
10 import 'span.dart'; 10 import 'span.dart';
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 buffer.write("\n"); 58 buffer.write("\n");
59 var textLine = text.split("\n").first; 59 var textLine = text.split("\n").first;
60 if (color != null) buffer.write(color); 60 if (color != null) buffer.write(color);
61 buffer.write(textLine); 61 buffer.write(textLine);
62 buffer.write("\n"); 62 buffer.write("\n");
63 buffer.write('^' * textLine.length); 63 buffer.write('^' * textLine.length);
64 if (color != null) buffer.write(colors.NONE); 64 if (color != null) buffer.write(colors.NONE);
65 return buffer.toString(); 65 return buffer.toString();
66 } 66 }
67 67
68 bool operator ==(SourceSpan other) => 68 bool operator ==(other) => other is SourceSpan &&
69 start == other.start && end == other.end; 69 start == other.start && end == other.end;
70 70
71 int get hashCode => start.hashCode + (31 * end.hashCode); 71 int get hashCode => start.hashCode + (31 * end.hashCode);
72 72
73 String toString() => '<$runtimeType: from $start to $end "$text">'; 73 String toString() => '<$runtimeType: from $start to $end "$text">';
74 } 74 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698