gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc - Issue 754433003: Update from https://crrev.com/305340

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

Issue 754433003: Update from https://crrev.com/305340 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

index a858cf7b59c38492daf090daf0e776fbeb23bfe5..fd28f758259588a325f495f63dec73cc72272189 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc

@@ -54,8 +54,7 @@ namespace gles2 {

using namespace cmds;

TEST_P(GLES2DecoderWithShaderTest, GetVertexAttribPointervSucceeds) {

- const float dummy = 0;

- const GLuint kOffsetToTestFor = sizeof(dummy) * 4;

+ const GLuint kOffsetToTestFor = sizeof(float) * 4;

const GLuint kIndexToTest = 1;

GetVertexAttribPointerv::Result* result =

static_cast<GetVertexAttribPointerv::Result*>(shared_memory_address_);